← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~cjwatson/launchpad/refactor-macaroon-testing into lp:launchpad

 

I thought actually returning a list of violations was a bit too confusing (because it would mean inverting the sense of boolean tests of verifyMacaroon), but passing a list as an optional argument which verifyMacaroon appends to seems not too horrible and works fine, so I've done that.
-- 
https://code.launchpad.net/~cjwatson/launchpad/refactor-macaroon-testing/+merge/365859
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References