launchpad-reviewers team mailing list archive

[Ioana Lasc <ioana.lasc@xxxxxxxxxxxxx>]

Ioana Lasc has proposed merging ~ilasc/launchpad:bug-1651826 into launchpad:master.

Commit message:
LP: #1651826 Mentioned on the Git Import Page that it won't be possible to push to push directly to the imported repository.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1817558 in Launchpad itself: "Snap source channels description is inaccurate when bases are in play"
  https://bugs.launchpad.net/launchpad/+bug/1817558

For more details, see:
https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/373860
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:bug-1651826 into launchpad:master.

diff --git a/lib/lp/code/browser/codeimport.py b/lib/lp/code/browser/codeimport.py
index dc7d9e6..4bd38dd 100644
--- a/lib/lp/code/browser/codeimport.py
+++ b/lib/lp/code/browser/codeimport.py
@@ -282,7 +282,8 @@ class NewCodeImportForm(Interface):
             "The URL of the Git repository.  For imports to Bazaar, the "
             "HEAD branch will be imported by default, but you can import "
             "different branches by appending ',branch=$name' to the URL.  "
-            "For imports to Git, the entire repository will be imported."),
+            "For imports to Git, the entire repository will be imported.  "
+            "You will not be able to push directly to the imported repository."),
         allowed_schemes=["git", "http", "https"],
         allow_userinfo=True,
         allow_port=True,
diff --git a/lib/lp/code/stories/codeimport/xx-create-codeimport.txt b/lib/lp/code/stories/codeimport/xx-create-codeimport.txt
index 6825114..86113f3 100644
--- a/lib/lp/code/stories/codeimport/xx-create-codeimport.txt
+++ b/lib/lp/code/stories/codeimport/xx-create-codeimport.txt
@@ -189,6 +189,11 @@ a name for the import branch, and a Git repository location.
     >>> browser.open("http://code.launchpad.test/+code-imports/+new";)
     >>> browser.getControl('Project').value = "firefox"
     >>> browser.getControl('Name').value = "git-import"
+
+Mention that the user won't be able to push directly to the imported repository.
+    >>> 'You will not be able to push directly to the imported repository' in browser.contents
+    True
+
     >>> browser.getControl('Git', index=0).click()
     >>> browser.getControl('Repo URL', index=0).value = (
     ...     "git://example.com/firefox.git")