launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/launchpad:pending-builds-msg-fix into launchpad:master.

Commit message:
Fixing singular message "A recent upload has resulted in 1 pending builds."

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1179354 in Launchpad itself: "Bad grammar: "A recent upload has resulted in 1 pending builds.""
  https://bugs.launchpad.net/launchpad/+bug/1179354

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/377010
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:pending-builds-msg-fix into launchpad:master.

diff --git a/lib/lp/soyuz/templates/archive-macros.pt b/lib/lp/soyuz/templates/archive-macros.pt
index 845eabf..5c0527c 100644
--- a/lib/lp/soyuz/templates/archive-macros.pt
+++ b/lib/lp/soyuz/templates/archive-macros.pt
@@ -273,7 +273,13 @@ div.package-details {
     A recent upload has resulted in
     <span class="build-count pending"
           tal:content="view/build_counters/pending">100</span>
-    pending builds.
+    pending
+    <tal:singular
+        condition="python: view.build_counters['pending'] == 1"
+        replace="string:build." />
+    <tal:plural
+        condition="python: view.build_counters['pending'] != 1"
+        replace="string:builds." />
   </p>
   </div>
 </metal:build_status_summary>