launchpad-reviewers team mailing list archive

[Dave Jones <dave.jones@xxxxxxxxxxxxx>]

Review: Approve

One minor comment, but otherwise looks fine

Diff comments:

> 
> === modified file 'lpbuildd/target/build_livefs.py'
> --- lpbuildd/target/build_livefs.py	2019-12-16 19:23:47 +0000
> +++ lpbuildd/target/build_livefs.py	2020-01-15 11:57:20 +0000
> @@ -76,6 +76,9 @@
>              "--channel", metavar="CHANNEL",
>              help="pull snaps from channel CHANNEL for ubuntu-core image")
>          parser.add_argument(
> +            "--build_id", metavar="BUILD_ID",

My only quibble here is that, for consistency with the other parameters, this probably ought to be "--build-id" rather than "--build_id"

> +            help="optional build ID to be passed to the image build")
> +        parser.add_argument(
>              "--http-proxy", action="store", help="use this HTTP proxy for apt")
>          parser.add_argument(
>              "--debug", default=False, action="store_true",


-- 
https://code.launchpad.net/~sil2100/launchpad-buildd/pass_build_id/+merge/377635
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sil2100/launchpad-buildd/pass_build_id into lp:launchpad-buildd.