launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/soyuz/templates/distroseries-queue.pt b/lib/lp/soyuz/templates/distroseries-queue.pt
> index 39629ce..3850174 100644
> --- a/lib/lp/soyuz/templates/distroseries-queue.pt
> +++ b/lib/lp/soyuz/templates/distroseries-queue.pt
> @@ -147,10 +147,14 @@
>                  </td>
>               </tr>
>             </tbody>
> -           <tbody tal:attributes="class string:${filelist_class}">
> +           <tbody tal:attributes="class string:${filelist_class}"
> +                  tal:define="hasActions python: len(view.availableActions()) > 0">
>               <metal:filelist use-macro="template/macros/package-filelist"/>
> +
>               <tr class="log-content" tal:repeat="log packageupload/logs">
> -               <td colspan="2" style="border: 0"></td>
> +               <td tal:attributes="colspan python: 2 if hasActions else 1"
> +                   style="border: 0"></td>
> +
>                 <td colspan="8" style="border: 0">

Actually, I think there are always 8 columns after the expand arrow (or expand arrow + checkbox).
So, it should be:
- 2 padding on the left + 8 columns on the right (when there is a checkbox)
- 1 padding on the left + 8 columns on the right (when there is no checkbox)

Having a colspan of 9 wouldn't break anything, but I think the correct value should be 8 in this case.

>                   <span tal:content="log/new_status"></span>
>                   <span tal:attributes="title log/date_created/fmt:datetime"


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/378679
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:pgk-upload-log-positioning into launchpad:master.