launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/bugs/interfaces/bugattachment.py b/lib/lp/bugs/interfaces/bugattachment.py
> index bbfa055..798b340 100644
> --- a/lib/lp/bugs/interfaces/bugattachment.py
> +++ b/lib/lp/bugs/interfaces/bugattachment.py
> @@ -126,6 +126,14 @@ class IBugAttachment(IHasBug):
>          description=_('Is this attachment a patch?'),
>          readonly=True)
>  
> +    def canRemoveFromBug(user):
> +        """Checks if this attachment can be removed from bug by the given
> +        user.
> +
> +        An attachment can only be removed by admin users, launchpad
> +        developers, bug owner or by the user who uploaded the attachment.

Is this list of allowed users enough?

> +        """
> +
>      @call_with(user=REQUEST_USER)
>      @export_write_operation()
>      def removeFromBug(user):


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/381537
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:bug-attachment-removal-restrictions into launchpad:master.