launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~pappacena/launchpad:bug-attachment-removal-restrictions into launchpad:master

To: "Thiago F. Pappacena" <pappacena@xxxxxxxxx>
From: Ioana Lasc <ioana.lasc@xxxxxxxxxxxxx>
Date: Thu, 02 Apr 2020 11:14:15 -0000
In-reply-to: <158577428341.18107.6469774561542281238.launchpad@ackee.canonical.com>
Reply-to: mp+381537@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Code looks good to me but I would have the same question as Thiago typed himself inline: is this list what we want: attachments can be removed by admin users, launchpad developers, bug owner or by the user who uploaded the attachment?

Unit Tests also look good, one question: this test case might be in there and I might be missing this but if answer to above is yes, should we also test for LP developers being able delete ?
-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/381537
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:bug-attachment-removal-restrictions into launchpad:master.

References

[Merge] ~pappacena/launchpad:bug-attachment-removal-restrictions into launchpad:master
From: Thiago F. Pappacena, 2020-04-01