launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/turnip:call-remove-str into turnip:master.

Commit message:
Tiny fix for proxy.callRemote call to make it compatible with python3.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/turnip/+git/turnip/+merge/383755
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/turnip:call-remove-str into turnip:master.

diff --git a/turnip/pack/hookrpc.py b/turnip/pack/hookrpc.py
index bcdcfd1..8c99e76 100644
--- a/turnip/pack/hookrpc.py
+++ b/turnip/pack/hookrpc.py
@@ -258,7 +258,7 @@ class HookRPCHandler(object):
         try:
             proxy = xmlrpc.Proxy(self.virtinfo_url, allowNone=True)
             mp_url = yield proxy.callRemote(
-                b'getMergeProposalURL', path, branch, auth_params).addTimeout(
+                'getMergeProposalURL', path, branch, auth_params).addTimeout(
                 self.virtinfo_timeout, self.reactor)
         except xmlrpc.Fault as e:
             code = translate_xmlrpc_fault(e.faultCode)