launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/turnip:null-bytes-tests-py3-compat into turnip:master.

Commit message:
Fixing tests to make assertion pass both on python2 and python3.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/turnip/+git/turnip/+merge/383756
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/turnip:null-bytes-tests-py3-compat into turnip:master.

diff --git a/turnip/pack/tests/test_helpers.py b/turnip/pack/tests/test_helpers.py
index 59c7827..e01406b 100644
--- a/turnip/pack/tests/test_helpers.py
+++ b/turnip/pack/tests/test_helpers.py
@@ -92,7 +92,7 @@ class TestDecodeRequest(TestCase):
         req = b'git-upload-pack /test_repo\0host=git.launchpad.test\0\0ver=2\0'
         self.assertEqual(
             (b'git-upload-pack', b'/test_repo',
-                {b'host': 'git.launchpad.test', 'ver': '2'}),
+                {b'host': b'git.launchpad.test', b'ver': b'2'}),
             helpers.decode_request(req))
 
     def test_parse_multiple_extra_params_after_2_null_bytes(self):
@@ -103,8 +103,8 @@ class TestDecodeRequest(TestCase):
                )
         self.assertEqual(
             (b'git-upload-pack', b'/test_repo',
-                {b'host': 'git.launchpad.test', 'ver': '2',
-                 'param2': 'value2', 'param3': 'value3'}),
+                {b'host': b'git.launchpad.test', b'ver': b'2',
+                 b'param2': b'value2', b'param3': b'value3'}),
             helpers.decode_request(req))
 
     def test_rejects_extra_param_without_end_null_bytes(self):