launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #24711
[Merge] ~pappacena/turnip:make-target-py3-check into turnip:master
Thiago F. Pappacena has proposed merging ~pappacena/turnip:make-target-py3-check into turnip:master.
Commit message:
Adding Makefile rule to run `make check-python-compat` and run tests on both python 2 and python 3 envs.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~pappacena/turnip/+git/turnip/+merge/383759
--
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/turnip:make-target-py3-check into turnip:master.
diff --git a/Makefile b/Makefile
index c514366..11d0abc 100644
--- a/Makefile
+++ b/Makefile
@@ -80,6 +80,13 @@ pip-check: $(ENV)
check: pip-check test lint
+check-python-compat:
+ for i in 2 3; do \
+ make clean && \
+ VENV_ARGS="-p python$$i" make bootstrap && \
+ ARGS="-v" make check || break;\
+ done
+
run-api: $(ENV)
$(PSERVE) api.ini --reload