launchpad-reviewers team mailing list archive

[Ioana Lasc <ioana.lasc@xxxxxxxxxxxxx>]

Ioana Lasc has proposed merging ~ilasc/launchpad:bug-1883901 into launchpad:master.

Commit message:
Add Series column to Person:Livefs page.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1883901 in Launchpad itself: "Add Series to Person:livefs index page"
  https://bugs.launchpad.net/launchpad/+bug/1883901

For more details, see:
https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/385914

Person:Livefs page contains hundreds of entries in the table, added the Series column to the table.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:bug-1883901 into launchpad:master.

diff --git a/lib/lp/registry/browser/tests/test_person.py b/lib/lp/registry/browser/tests/test_person.py
index 0d5bce9..1264643 100644
--- a/lib/lp/registry/browser/tests/test_person.py
+++ b/lib/lp/registry/browser/tests/test_person.py
@@ -1386,9 +1386,14 @@ class TestPersonLiveFSView(BrowserTestCase):
             soupmatchers.Tag(
                 'Livefs date created', 'td',
                 text='%s' % date_formatter.displaydate()))
+        series_match = soupmatchers.HTMLContains(
+            soupmatchers.Tag(
+                'Livefs series', 'td',
+                text='%s' % livefs.distro_series.display_name))
         with person_logged_in(self.person):
             self.assertThat(view.render(), link_match)
             self.assertThat(view.render(), date_created_match)
+            self.assertThat(view.render(), series_match)
 
     def test_displays_no_livefs(self):
         view = create_initialized_view(
diff --git a/lib/lp/registry/templates/person-livefses.pt b/lib/lp/registry/templates/person-livefses.pt
index b292801..840d0f5 100644
--- a/lib/lp/registry/templates/person-livefses.pt
+++ b/lib/lp/registry/templates/person-livefses.pt
@@ -26,6 +26,7 @@
         <tbody>
           <tr class="head">
             <th>Name</th>
+            <th>Series</th>
             <th>Date created</th>
           </tr>
 
@@ -34,6 +35,7 @@
               <a tal:content="filesystem/name"
                  tal:attributes="href filesystem/fmt:url" />
             </td>
+            <td tal:content="filesystem/distro_series/display_name " />
             <td tal:content="filesystem/date_created/fmt:displaydate" />
           </tr>
         </tbody>