launchpad-reviewers team mailing list archive

["Thiago F. Pappacena" <pappacena@xxxxxxxxx>]

Thiago F. Pappacena has proposed merging ~pappacena/launchpad:ociproject-test-fixes into launchpad:master.

Commit message:
Fixing test for OCIProject based on projects (expected methods matching their permissions and a misplaced menu link reference breaking tests).

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/385928
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pappacena/launchpad:ociproject-test-fixes into launchpad:master.

diff --git a/lib/lp/registry/browser/product.py b/lib/lp/registry/browser/product.py
index aad1fc8..268952d 100644
--- a/lib/lp/registry/browser/product.py
+++ b/lib/lp/registry/browser/product.py
@@ -435,7 +435,6 @@ class ProductNavigationMenu(NavigationMenu):
     facet = 'overview'
     links = [
         'details',
-        'new_oci_project',
         'announcements',
         'downloads',
         ]
diff --git a/lib/lp/registry/tests/test_product.py b/lib/lp/registry/tests/test_product.py
index e70fbbc..d8c02e1 100644
--- a/lib/lp/registry/tests/test_product.py
+++ b/lib/lp/registry/tests/test_product.py
@@ -1,4 +1,4 @@
-# Copyright 2009-2013 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2020 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 __metaclass__ = type
@@ -125,6 +125,7 @@ from lp.translations.interfaces.translations import (
     TranslationsBranchImportMode,
     )
 
+
 PRIVATE_PROJECT_TYPES = [InformationType.PROPRIETARY]
 
 
@@ -843,8 +844,9 @@ class TestProduct(TestCaseWithFactory):
             'bug_reported_acknowledgement', 'bug_reporting_guidelines',
             'bug_sharing_policy', 'bug_subscriptions', 'bug_supervisor',
             'bug_tracking_usage', 'bugtargetname',
-            'bugtracker', 'canUserAlterAnswerContact', 'codehosting_usage',
-            'coming_sprints', 'commercial_subscription',
+            'bugtracker', 'canAdministerOCIProjects',
+            'canUserAlterAnswerContact',
+            'codehosting_usage', 'coming_sprints', 'commercial_subscription',
             'commercial_subscription_is_due', 'createBug',
             'createCustomLanguageCode', 'custom_language_codes',
             'date_next_suggest_packaging', 'datecreated', 'description',
@@ -863,8 +865,8 @@ class TestProduct(TestCaseWithFactory):
             'getEffectiveTranslationPermission', 'getExternalBugTracker',
             'getFAQ', 'getFirstEntryToImport', 'getLinkedBugWatches',
             'getMergeProposals', 'getMilestone', 'getMilestonesAndReleases',
-            'getQuestion', 'getQuestionLanguages', 'getPackage', 'getRelease',
-            'getSeries', 'getSubscription',
+            'getOCIProject', 'getQuestion', 'getQuestionLanguages',
+            'getPackage', 'getRelease', 'getSeries', 'getSubscription',
             'getSubscriptions', 'getSupportedLanguages', 'getTimeline',
             'getTopContributors', 'getTopContributorsGroupedByCategory',
             'getTranslationGroups', 'getTranslationImportQueueEntries',