← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~cjwatson/launchpad:fix-py3-personsubscriptions-comprehension-2 into launchpad:master

 

Colin Watson has proposed merging ~cjwatson/launchpad:fix-py3-personsubscriptions-comprehension-2 into launchpad:master.

Commit message:
Bump query count in TestPersonSubscriptionInfo by one

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/396246

This was incurred by the new BugTask preloading.  The test already ensures that it's a constant increase rather than linear.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:fix-py3-personsubscriptions-comprehension-2 into launchpad:master.
diff --git a/lib/lp/bugs/model/tests/test_personsubscriptioninfo.py b/lib/lp/bugs/model/tests/test_personsubscriptioninfo.py
index e4ddcde..a42b39d 100644
--- a/lib/lp/bugs/model/tests/test_personsubscriptioninfo.py
+++ b/lib/lp/bugs/model/tests/test_personsubscriptioninfo.py
@@ -502,7 +502,7 @@ class TestPersonSubscriptionInfo(TestCaseWithFactory):
         with StormStatementRecorder() as recorder:
             self.subscriptions.reload()
         # This should produce a very small number of queries.
-        self.assertThat(recorder, HasQueryCount(LessThan(6)))
+        self.assertThat(recorder, HasQueryCount(LessThan(7)))
         count_with_one_subscribed_duplicate = recorder.count
         # It should have the correct result.
         self.assertCollectionsAreEmpty(except_='from_duplicate')