launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-sys-exc-type into launchpad:master.

Commit message:
Stop using sys.exc_type (deprecated since Python 1.5!)

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/396275
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-sys-exc-type into launchpad:master.

diff --git a/lib/lp/archiveuploader/nascentuploadfile.py b/lib/lp/archiveuploader/nascentuploadfile.py
index b5ece79..a5b9090 100644
--- a/lib/lp/archiveuploader/nascentuploadfile.py
+++ b/lib/lp/archiveuploader/nascentuploadfile.py
@@ -566,7 +566,7 @@ class BaseBinaryUploadFile(PackageUploadFile):
         except Exception as e:
             yield UploadError(
                 "%s: extracting control file raised %s: %s. giving up."
-                 % (self.filename, sys.exc_type, e))
+                 % (self.filename, sys.exc_info()[0], e))
             return
 
         for mandatory_field in self.mandatory_fields: