launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-test-sprints-stringio into launchpad:master.

Commit message:
Port xx-sprints.txt to six.StringIO

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/398926
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-test-sprints-stringio into launchpad:master.

diff --git a/lib/lp/blueprints/stories/sprints/xx-sprints.txt b/lib/lp/blueprints/stories/sprints/xx-sprints.txt
index f1b0ced..cfda51f 100644
--- a/lib/lp/blueprints/stories/sprints/xx-sprints.txt
+++ b/lib/lp/blueprints/stories/sprints/xx-sprints.txt
@@ -489,8 +489,7 @@ First, we add a couple of IRC nicknames for Carlos.
 The resulting CSV file lists physical attendance correctly.
 
     >>> import csv
-    >>> from StringIO import StringIO
-    >>> ubz_csv = list(csv.DictReader(StringIO(browser.contents)))
+    >>> ubz_csv = list(csv.DictReader(six.StringIO(browser.contents)))
     >>> [(row["Launchpad username"], row["Physically present"])
     ...     for row in ubz_csv]
     [('carlos', 'True'), ('salgado', 'False'), ('name12', 'True')]
@@ -523,7 +522,7 @@ as attending remotely.
     >>> browser.getControl('Register').click()
 
     >>> browser.getLink('Export attendees to CSV').click()
-    >>> ltsp_csv = list(csv.DictReader(StringIO(browser.contents)))
+    >>> ltsp_csv = list(csv.DictReader(six.StringIO(browser.contents)))
     >>> [(row["Launchpad username"], row["Physically present"])
     ...     for row in ltsp_csv]
     [('name12', 'False')]