launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-case-insensitive-response-headers into launchpad:master.

Commit message:
Fix package-diff.txt for Python 3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/398929

resp.getheaders() returns a plain dict that doesn't support case-insensitive lookups.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-case-insensitive-response-headers into launchpad:master.

diff --git a/lib/lp/soyuz/doc/package-diff.txt b/lib/lp/soyuz/doc/package-diff.txt
index dc4830b..aaeb81d 100644
--- a/lib/lp/soyuz/doc/package-diff.txt
+++ b/lib/lp/soyuz/doc/package-diff.txt
@@ -390,12 +390,11 @@ for users to view it.
     >>> con = http_client.HTTPConnection(netloc)
     >>> con.request("HEAD", path)
     >>> resp = con.getresponse()
-    >>> headers = dict(resp.getheaders())
 
-    >>> print(headers['content-encoding'])
+    >>> print(resp.getheader('content-encoding'))
     gzip
 
-    >>> print(headers['content-type'])
+    >>> print(resp.getheader('content-type'))
     text/plain