launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/lib/lp/snappy/model/snap.py b/lib/lp/snappy/model/snap.py
> index 20dbf3d..e0760c5 100644
> --- a/lib/lp/snappy/model/snap.py
> +++ b/lib/lp/snappy/model/snap.py
> @@ -1121,6 +1128,14 @@ class Snap(Storm, WebhookTargetMixin):
>          order_by = Desc(SnapBuild.id)
>          return self._getBuilds(filter_term, order_by)
>  
> +    def visibleByUser(self, user):
> +        """See `IGitRepository`."""

ISnap rather than IGitRepository?

> +        store = IStore(self)
> +        return not store.find(
> +            Snap,
> +            Snap.id == self.id,
> +            get_snap_privacy_filter(user)).is_empty()
> +
>      def subscribe(self, person, subscribed_by, ignore_permissions=False):
>          """See `ISnap`."""
>          # XXX pappacena 2021-02-05: We may need a "SnapSubscription" here.


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/397693
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:snap-pillar-accesspolicy.