launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/snappy/model/snap.py b/lib/lp/snappy/model/snap.py
> index 7e3d14c..b298a86 100644
> --- a/lib/lp/snappy/model/snap.py
> +++ b/lib/lp/snappy/model/snap.py
> @@ -374,13 +392,17 @@ class Snap(Storm, WebhookTargetMixin):
>                   date_created=DEFAULT, private=False, allow_internet=True,
>                   build_source_tarball=False, store_upload=False,
>                   store_series=None, store_name=None, store_secrets=None,
> -                 store_channels=None):
> +                 store_channels=None, project=None):
>          """Construct a `Snap`."""
>          super(Snap, self).__init__()
>  
>          # Set the private flag first so that other validators can perform
> -        # suitable privacy checks.
> +        # suitable privacy checks, but pillar should also be set, since it's
> +        # mandatory for private snaps.
> +        self.project = project
>          self.private = private
> +        self.information_type = (InformationType.PROPRIETARY if private else
> +                                 InformationType.PUBLIC)

OK, fair enough.

>  
>          self.registrant = registrant
>          self.owner = owner


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/397458
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:snap-pillar.