launchpad-reviewers team mailing list archive

Thread
Date

[Merge] ~twom/launchpad:oci-remove-unnecessary-complete into launchpad:master

To: mp+399312@xxxxxxxxxxxxxxxxxx
From: Tom Wardill <tom.wardill@xxxxxxxxxxxxx>
Date: Mon, 08 Mar 2021 16:35:32 -0000
Reply-to: mp+399312@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Tom Wardill has proposed merging ~twom/launchpad:oci-remove-unnecessary-complete into launchpad:master.

Commit message:
Remove first complete from OCIRegistryUploadJob

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/399312

This complete appears to be masking failures, and is causing unnecessary OOPS on all RegistryUpload jobs as it causes an invalid transition of Complete -> Complete.

Without managing the transaction, this also appears to be unnecessary?
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~twom/launchpad:oci-remove-unnecessary-complete into launchpad:master.