launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:unused-imports into launchpad:master.

Commit message:
Remove various unused imports

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/399329
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:unused-imports into launchpad:master.

diff --git a/cronscripts/process-job-source-groups.py b/cronscripts/process-job-source-groups.py
index 01ab9a7..8d10901 100755
--- a/cronscripts/process-job-source-groups.py
+++ b/cronscripts/process-job-source-groups.py
@@ -19,7 +19,6 @@ from lp.services.config import config
 from lp.services.helpers import english_list
 from lp.services.propertycache import cachedproperty
 from lp.services.scripts.base import LaunchpadCronScript
-from lp.services.job.scripts.process_job_source import ProcessJobSource
 
 
 class LongEpilogHelpFormatter(IndentedHelpFormatter):
diff --git a/lib/lp/bugs/mail/bugnotificationbuilder.py b/lib/lp/bugs/mail/bugnotificationbuilder.py
index 0846bb7..e525806 100644
--- a/lib/lp/bugs/mail/bugnotificationbuilder.py
+++ b/lib/lp/bugs/mail/bugnotificationbuilder.py
@@ -27,8 +27,6 @@ from lp.app.enums import (
     )
 from lp.app.interfaces.launchpad import ILaunchpadCelebrities
 from lp.services.config import config
-from lp.services.helpers import shortlist
-from lp.services.identity.interfaces.emailaddress import IEmailAddressSet
 from lp.services.mail.sendmail import (
     append_footer,
     format_address,
diff --git a/lib/lp/code/browser/tests/test_branch.py b/lib/lp/code/browser/tests/test_branch.py
index cb2ea66..b731ac7 100644
--- a/lib/lp/code/browser/tests/test_branch.py
+++ b/lib/lp/code/browser/tests/test_branch.py
@@ -12,7 +12,6 @@ from textwrap import dedent
 
 from fixtures import FakeLogger
 import pytz
-from six.moves.urllib_error import HTTPError
 from storm.store import Store
 from testtools.matchers import Equals
 from zope.component import getUtility
diff --git a/lib/lp/registry/browser/person.py b/lib/lp/registry/browser/person.py
index 31c29ed..8311bd1 100644
--- a/lib/lp/registry/browser/person.py
+++ b/lib/lp/registry/browser/person.py
@@ -192,7 +192,6 @@ from lp.registry.interfaces.product import (
     InvalidProductName,
     IProduct,
     )
-from lp.registry.interfaces.role import IPersonRoles
 from lp.registry.interfaces.ssh import (
     ISSHKeySet,
     SSHKeyAdditionError,
diff --git a/lib/lp/registry/tests/test_distributionmirror.py b/lib/lp/registry/tests/test_distributionmirror.py
index e2fcc36..bbe025d 100644
--- a/lib/lp/registry/tests/test_distributionmirror.py
+++ b/lib/lp/registry/tests/test_distributionmirror.py
@@ -20,7 +20,6 @@ from lp.registry.interfaces.pocket import PackagePublishingPocket
 from lp.registry.model.distributionmirror import DistributionMirror
 from lp.services.database.sqlbase import flush_database_updates
 from lp.services.mail import stub
-from lp.services.webapp.authorization import check_permission
 from lp.services.worlddata.interfaces.country import ICountrySet
 from lp.testing import (
     login,
diff --git a/lib/lp/registry/tests/test_ociprojectname.py b/lib/lp/registry/tests/test_ociprojectname.py
index 99d14bb..09411f5 100644
--- a/lib/lp/registry/tests/test_ociprojectname.py
+++ b/lib/lp/registry/tests/test_ociprojectname.py
@@ -7,7 +7,6 @@ from __future__ import absolute_import, print_function, unicode_literals
 
 __metaclass__ = type
 
-from testtools.testcase import ExpectedException
 from zope.component import getUtility
 
 from lp.registry.errors import (
@@ -22,10 +21,7 @@ from lp.registry.model.ociprojectname import (
     OCIProjectName,
     OCIProjectNameSet,
     )
-from lp.testing import (
-    admin_logged_in,
-    TestCaseWithFactory,
-    )
+from lp.testing import TestCaseWithFactory
 from lp.testing.layers import DatabaseFunctionalLayer
 
 
diff --git a/lib/lp/services/database/tests/script_isolation.py b/lib/lp/services/database/tests/script_isolation.py
index 6f9843b..9857c13 100644
--- a/lib/lp/services/database/tests/script_isolation.py
+++ b/lib/lp/services/database/tests/script_isolation.py
@@ -10,8 +10,6 @@ from __future__ import absolute_import, print_function
 __metaclass__ = type
 __all__ = []
 
-import warnings
-
 import transaction
 
 from lp.services.config import dbconfig
diff --git a/lib/lp/services/webapp/authentication.py b/lib/lp/services/webapp/authentication.py
index c778407..01e5e53 100644
--- a/lib/lp/services/webapp/authentication.py
+++ b/lib/lp/services/webapp/authentication.py
@@ -15,7 +15,6 @@ __all__ = [
 import binascii
 
 from oauthlib import oauth1
-from oauthlib.oauth1.rfc5849.utils import parse_authorization_header
 import six
 from zope.authentication.interfaces import ILoginPassword
 from zope.component import getUtility
diff --git a/lib/lp/soyuz/browser/tests/test_distroarchseries_webservice.py b/lib/lp/soyuz/browser/tests/test_distroarchseries_webservice.py
index 2a89f35..4555f60 100644
--- a/lib/lp/soyuz/browser/tests/test_distroarchseries_webservice.py
+++ b/lib/lp/soyuz/browser/tests/test_distroarchseries_webservice.py
@@ -23,7 +23,6 @@ from lp.buildmaster.enums import BuildBaseImageType
 from lp.registry.enums import PersonVisibility
 from lp.registry.interfaces.pocket import PackagePublishingPocket
 from lp.services.features.testing import FeatureFixture
-from lp.soyuz.enums import DistroArchSeriesFilterSense
 from lp.soyuz.interfaces.livefs import LIVEFS_FEATURE_FLAG
 from lp.testing import (
     api_url,
diff --git a/lib/lp/soyuz/model/queue.py b/lib/lp/soyuz/model/queue.py
index 9fdfb5f..712acfb 100644
--- a/lib/lp/soyuz/model/queue.py
+++ b/lib/lp/soyuz/model/queue.py
@@ -76,7 +76,6 @@ from lp.services.database.stormexpr import (
     Array,
     ArrayContains,
     )
-from lp.services.features import getFeatureFlag
 from lp.services.librarian.browser import ProxiedLibraryFileAlias
 from lp.services.librarian.model import (
     LibraryFileAlias,
diff --git a/lib/lp/testing/swift/fakeswift.py b/lib/lp/testing/swift/fakeswift.py
index 3536326..2039e74 100644
--- a/lib/lp/testing/swift/fakeswift.py
+++ b/lib/lp/testing/swift/fakeswift.py
@@ -18,7 +18,6 @@ import io
 import json
 import logging
 import os.path
-import sys
 import time
 import uuid
 
diff --git a/lib/lp/testing/swift/tests/test_fixture.py b/lib/lp/testing/swift/tests/test_fixture.py
index b03507f..2fbc3eb 100644
--- a/lib/lp/testing/swift/tests/test_fixture.py
+++ b/lib/lp/testing/swift/tests/test_fixture.py
@@ -11,7 +11,6 @@ from hashlib import md5
 
 from requests.exceptions import ConnectionError
 from swiftclient import client as swiftclient
-from swiftclient.exceptions import ClientException
 from testtools.matchers import (
     GreaterThan,
     LessThan,
diff --git a/utilities/findimports.py b/utilities/findimports.py
index 09e0cf1..90367ed 100755
--- a/utilities/findimports.py
+++ b/utilities/findimports.py
@@ -39,7 +39,6 @@ Ave, Cambridge, MA 02139, USA.
 from __future__ import absolute_import, print_function
 
 import compiler
-from compiler import ast
 from compiler.visitor import ASTVisitor
 import getopt
 import linecache