launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/lib/lp/bugs/templates/bugcomment-box.pt b/lib/lp/bugs/templates/bugcomment-box.pt
> index 1b087d7..35c3c10 100644
> --- a/lib/lp/bugs/templates/bugcomment-box.pt
> +++ b/lib/lp/bugs/templates/bugcomment-box.pt
> @@ -47,13 +56,26 @@
>                  datetime comment/datecreated/fmt:isodate"
>                tal:content="comment/datecreated/fmt:displaydate">
>                7 minutes ago
> -              </time>:
> +              </time><span class="editable-message-last-edit-date"><span tal:condition="not:context/date_last_edited">:</span>

As in https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/402522, it would be nice to avoid having to render the colon in two places with relatively large amounts of tag noise around them.

> +                <tal:last-edit condition="context/date_last_edited">
> +                  (last edit <time
> +                      itemprop="editTime"
> +                      tal:attributes="title context/date_last_edited/fmt:datetime;
> +                        datetime context/date_last_edited/fmt:isodate"
> +                      tal:content="context/date_last_edited/fmt:displaydate" />):
> +                </tal:last-edit>
> +              </span>
>                <a tal:attributes="href comment/fmt:url">
>                  <strong tal:condition="comment/display_title"
>                          tal:content="comment/title" />
>                </a>
>            </td>
>  
> +          <td>
> +            <img class="sprite edit action-icon editable-message-edit-btn"
> +                 tal:condition="view/can_edit"/>
> +          </td>
> +
>            <td class="bug-comment-index">
>            <a itemprop="url"
>               tal:attributes="href comment/fmt:url"


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/402604
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:comment-editing-ui.