launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/lib/lp/code/templates/codereviewcomment-header.pt b/lib/lp/code/templates/codereviewcomment-header.pt
> index efd37eb..254e764 100644
> --- a/lib/lp/code/templates/codereviewcomment-header.pt
> +++ b/lib/lp/code/templates/codereviewcomment-header.pt
> @@ -18,7 +18,15 @@
>              datetime context/comment_date/fmt:isodate"
>            tal:content="context/comment_date/fmt:displaydate">
>            7 minutes ago
> -        </time>:
> +        </time><span class="editable-message-last-edit-date"><span tal:condition="not:context/date_last_edited">:</span>

As in https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/402522, it would be nice to avoid having to render the colon in two places with relatively large amounts of tag noise around them.

> +            <tal:last-edit condition="context/date_last_edited">
> +              (last edit <time
> +                  itemprop="editTime"
> +                  tal:attributes="title context/date_last_edited/fmt:datetime;
> +                    datetime context/date_last_edited/fmt:isodate"
> +                  tal:content="context/date_last_edited/fmt:displaydate" />):
> +            </tal:last-edit>
> +          </span>
>          <span
>            tal:condition="context/from_superseded"
>            class="sprite warning-icon"


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/402850
Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:comment-editing-ui-bugcomment.