launchpad-reviewers team mailing list archive

[Cristian Gonzalez <mp+406982@xxxxxxxxxxxxxxxxxx>]

Cristian Gonzalez has proposed merging ~cristiangsp/launchpad:fixing-autocompletejs-linting into launchpad:master.

Commit message:
Fixing linting in autocomplete.js file

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cristiangsp/launchpad/+git/launchpad/+merge/406982

Fixing linting in autocomplete.js file
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cristiangsp/launchpad:fixing-autocompletejs-linting into launchpad:master.

diff --git a/lib/lp/app/javascript/autocomplete.js b/lib/lp/app/javascript/autocomplete.js
index b808eba..1f35175 100644
--- a/lib/lp/app/javascript/autocomplete.js
+++ b/lib/lp/app/javascript/autocomplete.js
@@ -9,7 +9,7 @@ YUI.add('lp.app.autocomplete', function (Y) {
     namespace.getRepositoryCompletionURI = function (repo_node) {
         var entered_uri = repo_node.get('value');
         if (entered_uri.startsWith("lp:")) {
-            var split = "+code/" + entered_uri.split("lp:")[1]
+            var split = "+code/" + entered_uri.split("lp:")[1];
             entered_uri = encodeURI(split);
         }
         else if (entered_uri.startsWith("~")) {
@@ -29,7 +29,7 @@ YUI.add('lp.app.autocomplete', function (Y) {
         uri += entered_uri;
         uri += '/@@+huge-vocabulary';
         return uri;
-    }
+    };
 
     namespace.getRepoNode = function (path_node) {
         var split = path_node._node['id'].split('.');
@@ -37,7 +37,7 @@ YUI.add('lp.app.autocomplete', function (Y) {
         var repository_target = split.join('.');
         var target_repo = Y.one('[id="' + repository_target + '"]');
         return target_repo;
-    }
+    };
 
     namespace.getPathNode = function (path_node) {
         var split = path_node._node['id'].split('.');
@@ -45,7 +45,7 @@ YUI.add('lp.app.autocomplete', function (Y) {
         var path_target = split.join('.');
         var target_path = Y.one('[id="' + path_target + '"]');
         return target_path;
-    }
+    };
 
     namespace.setupVocabAutocomplete = function (config, node) {
         var qs = 'name=' + encodeURIComponent(config.vocabulary_name);
@@ -72,7 +72,7 @@ YUI.add('lp.app.autocomplete', function (Y) {
             var uri = namespace.getRepositoryCompletionURI(this);
             var path_node = namespace.getPathNode(this);
             path_node.ac.set("source", uri);
-        }
+        };
         // ideally this should take node to rebind `this` in the function
         // but we're also calling it from the popup picker, which has a direct
         // reference to the repo_node, so maintain the local `this` binding.