launchpad-reviewers team mailing list archive

[Cristian Gonzalez <mp+406983@xxxxxxxxxxxxxxxxxx>]

Cristian Gonzalez has proposed merging ~cristiangsp/launchpad:fixing-formoverlayjs-linting into launchpad:master.

Commit message:
Fixing linting in formoverlay.js file

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cristiangsp/launchpad/+git/launchpad/+merge/406983

Fixing linting in formoverlay.js file
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cristiangsp/launchpad:fixing-formoverlayjs-linting into launchpad:master.

diff --git a/lib/lp/app/javascript/formoverlay/formoverlay.js b/lib/lp/app/javascript/formoverlay/formoverlay.js
index cd3481e..bb5ef75 100644
--- a/lib/lp/app/javascript/formoverlay/formoverlay.js
+++ b/lib/lp/app/javascript/formoverlay/formoverlay.js
@@ -516,11 +516,14 @@ Y.extend(FormOverlay, Y.lp.ui.PrettyOverlay, {
                     case 'file':
                         // stub case as XMLHttpRequest will only send
                         // the file path as a string.
+                        break;
                     case undefined:
                         // stub case for fieldset element which returns
                         // undefined.
+                        break;
                     case 'reset':
                         // stub case for input type reset button.
+                        break;
                     case 'button':
                         // stub case for input type button elements.
                         break;