launchpad-reviewers team mailing list archive

[Cristian Gonzalez <mp+406984@xxxxxxxxxxxxxxxxxx>]

Cristian Gonzalez has proposed merging ~cristiangsp/launchpad:fixing-standard_test_templatejs-linting into launchpad:master.

Commit message:
Fixing standard_test_template.js linting

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cristiangsp/launchpad/+git/launchpad/+merge/406984

Fixing standard_test_template.js linting
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cristiangsp/launchpad:fixing-standard_test_templatejs-linting into launchpad:master.

diff --git a/standard_test_template.js b/standard_test_template.js
index a368983..08e40ab 100644
--- a/standard_test_template.js
+++ b/standard_test_template.js
@@ -1,24 +1,24 @@
 /* Copyright 2021 Canonical Ltd.  This software is licensed under the
  * GNU Affero General Public License version 3 (see the file LICENSE). */
 
-YUI.add('lp.${LIBRARY}.test', function (Y) {
+YUI.add('lp.$LIBRARY.test', function (Y) {
 
-    var tests = Y.namespace('lp.${LIBRARY}.test');
-    tests.suite = new Y.Test.Suite('${LIBRARY} Tests');
+    var tests = Y.namespace('lp.$LIBRARY.test');
+    tests.suite = new Y.Test.Suite('$LIBRARY Tests');
 
     tests.suite.add(new Y.Test.Case({
-        name: '${LIBRARY}_tests',
+        name: '$LIBRARY_tests',
 
         setUp: function () {},
         tearDown: function () {},
 
         test_library_exists: function () {
-            Y.Assert.isObject(Y.lp.${LIBRARY},
-                "Could not locate the lp.${LIBRARY} module");
+            Y.Assert.isObject(Y.lp.$LIBRARY,
+                "Could not locate the lp.$LIBRARY module");
         }
 
     }));
 
 }, '0.1', {
-    requires: ['test', 'lp.testing.helpers', 'console', 'lp.${LIBRARY}']
+    requires: ['test', 'lp.testing.helpers', 'console', 'lp.$LIBRARY']
 });