launchpad-reviewers team mailing list archive

[Cristian Gonzalez <mp+407005@xxxxxxxxxxxxxxxxxx>]

Cristian Gonzalez has proposed merging ~cristiangsp/launchpad:fixing-test_filebug_dupefinderjs-linting into launchpad:master.

Commit message:
Fixing test_filebug_dupefinder.js linting

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cristiangsp/launchpad/+git/launchpad/+merge/407005

Fixing test_filebug_dupefinder.js linting
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cristiangsp/launchpad:fixing-test_filebug_dupefinderjs-linting into launchpad:master.

diff --git a/lib/lp/bugs/javascript/tests/test_filebug_dupefinder.js b/lib/lp/bugs/javascript/tests/test_filebug_dupefinder.js
index eb85aff..e7159f1 100644
--- a/lib/lp/bugs/javascript/tests/test_filebug_dupefinder.js
+++ b/lib/lp/bugs/javascript/tests/test_filebug_dupefinder.js
@@ -24,18 +24,18 @@ YUI.add('lp.bugs.filebug_dupefinder.test', function (Y) {
             throw new Error("Constructor called as a function");
         }
         this.calls = [];
-        this.io = function(url, config) {
+        this.io = function io_handler(url, config) {
             this.calls.push(url);
             var response = {responseText: ''};
             // We may have been passed text to use in the response.
-            if (Y.Lang.isValue(arguments.callee.responseText)) {
-                response.responseText = arguments.callee.responseText;
+            if (Y.Lang.isValue(io_handler.responseText)) {
+                response.responseText = io_handler.responseText;
             }
             // We currently only support calling the success handler.
-            config.on.success(undefined, response, arguments.callee.args);
+            config.on.success(undefined, response, io_handler.args);
             // After calling the handler, resume the test.
-            if (Y.Lang.isFunction(arguments.callee.doAfter)) {
-                test_case.resume(arguments.callee.doAfter);
+            if (Y.Lang.isFunction(io_handler.doAfter)) {
+                test_case.resume(io_handler.doAfter);
             }
         };
     }