launchpad-reviewers team mailing list archive

[Ioana Lasc <mp+407006@xxxxxxxxxxxxxxxxxx>]

Ioana Lasc has proposed merging ~ilasc/launchpad:eslint-fix-no-new into launchpad:master.

Commit message:
Fix no-new in test_team_mailinglists.js

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/407006

We need the new operator in there otherwise we fail with:

Failure in '
 '/home/ilasc/launchpad/launchpad/lib/lp/registry/javascript/tests/test_team_mailinglists.html.Team '
 'Mailinglists.test_nav: Unexpected error: undefined is not a function '
 "(evaluating 'this._initBase(cfg)'
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:eslint-fix-no-new into launchpad:master.

diff --git a/lib/lp/registry/javascript/tests/test_team_mailinglists.js b/lib/lp/registry/javascript/tests/test_team_mailinglists.js
index a196b0f..ef11e98 100644
--- a/lib/lp/registry/javascript/tests/test_team_mailinglists.js
+++ b/lib/lp/registry/javascript/tests/test_team_mailinglists.js
@@ -54,6 +54,7 @@ YUI.add('lp.registry.team.mailinglists.test', function (Y) {
                 forwards_navigation: Y.all('.last,.next'),
                 backwards_navigation: Y.all('.first,.previous')
             };
+            /* eslint-disable no-new */
             new Y.lp.registry.team.mailinglists.MessageList(config);
 
             var fired = false;