launchpad-reviewers team mailing list archive

[Colin Watson <mp+414097@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/bugs/enums.py b/lib/lp/bugs/enums.py
> index 6290763..3a0a09d 100644
> --- a/lib/lp/bugs/enums.py
> +++ b/lib/lp/bugs/enums.py
> @@ -74,3 +74,24 @@ class BugNotificationStatus(DBEnumeratedType):
>          The notification is deferred.  The recipient list was not calculated
>          at creation time but is done when processed.
>          """)
> +
> +
> +class BugLockStatus(DBEnumeratedType):
> +    """
> +    The lock status of a bug.
> +
> +    The lock status may be unlocked, comment-only.
> +    """
> +
> +    UNLOCKED = DBItem(0, """
> +        Unlocked
> +
> +        The bug is unlocked and the usual permissions apply.
> +        """)
> +
> +    COMMENT_ONLY = DBItem(1, """
> +        Comment-only
> +
> +        The bug allows those without a bug role or an admin role
> +        to comment.

As you pointed out, this isn't right.  Revised suggestion:

  The bug allows those without a bug role to comment, but not to edit metadata.

> +        """)


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/414097
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:enforce-stricter-permission-check-when-a-bug-is-locked-down into launchpad:master.