launchpad-reviewers team mailing list archive

[Guruprasad <mp+414097@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/bugs/model/bug.py b/lib/lp/bugs/model/bug.py
> index 0a3ff8c..0575305 100644
> --- a/lib/lp/bugs/model/bug.py
> +++ b/lib/lp/bugs/model/bug.py
> @@ -387,6 +390,9 @@ class Bug(SQLBase, InformationTypeMixin):
>      heat = IntCol(notNull=True, default=0)
>      heat_last_updated = UtcDateTimeCol(default=None)
>      latest_patch_uploaded = UtcDateTimeCol(default=None)
> +    lock_status = DBEnum(
> +        enum=BugLockStatus, allow_none=False, default=BugLockStatus.UNLOCKED)

I do not expect to land this before the corresponding DB change and the backfill process is completed. So we decided to ignore this comment after discussing it on Mattermost.

> +    lock_reason = StringCol(notNull=False, default=None)
>  
>      @property
>      def linked_branches(self):


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/414097
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:enforce-stricter-permission-check-when-a-bug-is-locked-down into launchpad:master.