launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~lgp171188/launchpad:new-security-role-permission into launchpad:master

To: Guruprasad <guruprasad.ln@xxxxxxxxxxxxx>
From: Andrey Fedoseev <mp+423363@xxxxxxxxxxxxxxxxxx>
Date: Thu, 26 May 2022 09:49:05 -0000
In-reply-to: <165347690532.28357.8775706108030582013.launchpad@ackee.canonical.com>
Reply-to: mp+423363@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

This looks good.

I have doubts about the the permission name: `SecurityAdmin`. I think there's a convention to use a verb in the permission names. `SecurityAdmin` sounds more like a role than a permission.

Could it be `ManageVulnerabilties` or `AdministerVulnerabilities` instead?
-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/423363
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:new-security-role-permission into launchpad:master.

References

[Merge] ~lgp171188/launchpad:new-security-role-permission into launchpad:master
From: Guruprasad, 2022-05-25