launchpad-reviewers team mailing list archive

[Guruprasad <mp+423363@xxxxxxxxxxxxxxxxxx>]

> I have doubts about the the permission name: `SecurityAdmin`. I think there's a convention to use a verb in the permission names. `SecurityAdmin` sounds more like a role than a permission.
>
> Could it be `ManageVulnerabilties` or `AdministerVulnerabilities` instead?

I thought about it when I was about to name it and found that there are some existing permissions that do not fit in this mould - `launchpad.AnyAllowedPerson`, `launchpad.AnyLegitimatePerson`, `launchpad.TranslationsAdmin`, `launchpad.LanguagePacksAdmin` etc. That is why I named it as `launchpad.SecurityAdmin`.

-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/423363
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:new-security-role-permission into launchpad:master.