launchpad-reviewers team mailing list archive

[Guruprasad <mp+423432@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/snappy/adapters/buildarch.py b/lib/lp/snappy/adapters/buildarch.py
> index fe8680b..127c734 100644
> --- a/lib/lp/snappy/adapters/buildarch.py
> +++ b/lib/lp/snappy/adapters/buildarch.py
> @@ -84,8 +84,10 @@ class SnapArchitecture:
>              raise MissingPropertyError("build-on")
>  
>          return cls(
> -            build_on=build_on, run_on=properties.get("run-on"),
> -            build_error=properties.get("build-error"))
> +            build_on=build_on,
> +            run_on=properties.get("run-on", properties.get("build-to")),

It is worth checking with Colin if this order of priority - check `run-on` first and if it isn't present, check for `build-to`, is the correct one to use.

> +            build_error=properties.get("build-error"),
> +        )
>  
>  
>  class SnapBuildInstance:


-- 
https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/423432
Your team Launchpad code reviewers is requested to review the proposed merge of ~andrey-fedoseev/launchpad:build-to-run-on-synonym into launchpad:master.