launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~lgp171188/launchpad:diff-viewer-fix-text-overflow into launchpad:master

To: Guruprasad <guruprasad.ln@xxxxxxxxxxxxx>
From: Guruprasad <mp+424302@xxxxxxxxxxxxxxxxxx>
Date: Tue, 28 Jun 2022 08:09:33 -0000
In-reply-to: <165478517566.12886.1322272548773219540.codereview@daniels.canonical.com>
Reply-to: mp+424302@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Andrey, `overflow: break-word` is a good choice for inserting line breaks between words in long sentences. However in the referenced MP, there are no words and `overflow: break-word` breaks on the hyphens in the values of the some svg attribute. I am not sure if that is such a good idea.

Colin, comments/thoughts?
-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/424302
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:diff-viewer-fix-text-overflow into launchpad:master.

References

Re: [Merge] ~lgp171188/launchpad:diff-viewer-fix-text-overflow into launchpad:master
From: Guruprasad, 2022-06-09