launchpad-reviewers team mailing list archive

[Colin Watson <mp+424302@xxxxxxxxxxxxxxxxxx>]

I tried these out interactively in Firefox.  I'm not sure I completely like either of these, but on balance I prefer Andrey's suggestion.  I agree that it's a _bit_ weird to break on hyphens in raw SVG files, but it's not like it's really human-readable anyway.  We have two basic cases here:

 * long lines in files that aren't reviewable as text (in this case it doesn't matter very much, and we might as well make it just not be terribly ugly)
 * long lines in files that are reviewable as text (in this case, `overflow-wrap: break-word` is likely to be reasonable)

The `table-layout: auto` change looks worse to my eye: I can see why you would have needed it with `overflow: scroll`, but it makes the line-number column uncomfortably narrow, and it's definitely worse overall with `overflow-wrap: break-word`.
-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/424302
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:diff-viewer-fix-text-overflow into launchpad:master.