launchpad-reviewers team mailing list archive

[Colin Watson <mp+429244@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:postgresql-11-doctest into launchpad:master.

Commit message:
Fix doctest failure with PostgreSQL >= 11

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/429244

PostgreSQL >= 11 issues the more specific error message of "permission denied for table sourcepackagename" rather than "permission denied for relation sourcepackagename".
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:postgresql-11-doctest into launchpad:master.

diff --git a/lib/lp/services/webapp/doc/test_adapter.rst b/lib/lp/services/webapp/doc/test_adapter.rst
index 8c535d4..fa5ff81 100644
--- a/lib/lp/services/webapp/doc/test_adapter.rst
+++ b/lib/lp/services/webapp/doc/test_adapter.rst
@@ -455,7 +455,7 @@ config section.  By default we connect as "launchpad"
     Traceback (most recent call last):
     ...
     storm.database.InsufficientPrivilege:
-    permission denied for relation sourcepackagename
+    permission denied for ... sourcepackagename
 
 This is not reset at the end of the transaction:
 
@@ -468,7 +468,7 @@ This is not reset at the end of the transaction:
     Traceback (most recent call last):
     ...
     storm.database.InsufficientPrivilege:
-    permission denied for relation sourcepackagename
+    permission denied for ... sourcepackagename
     >>> transaction.abort()
 
 So you need to explicitly set the user back to the default: