launchpad-reviewers team mailing list archive

[Colin Watson <mp+429245@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:poexport-queue-doctest into launchpad:master.

Commit message:
Fix poexport-queue doctest failure with Python >= 3.8.3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/429245

As of Python 3.8.3 (I think), the `patcher.stop()` call here returns False rather than None.  We don't care about this distinction; ignore it.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:poexport-queue-doctest into launchpad:master.

diff --git a/lib/lp/translations/doc/poexport-queue.rst b/lib/lp/translations/doc/poexport-queue.rst
index 9e3fa5e..0203016 100644
--- a/lib/lp/translations/doc/poexport-queue.rst
+++ b/lib/lp/translations/doc/poexport-queue.rst
@@ -144,7 +144,7 @@ inject a mock exception in that case so that the test can pass.
     >>> mock_failure = patcher.start()
     >>> mock_failure.__str__.side_effect = lambda: b'\xc3'.decode('UTF-8')
     >>> result.notify()
-    >>> patcher.stop()
+    >>> _ = patcher.stop()
 
     >>> test_emails = pop_notifications()
     >>> len(test_emails)