launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+429822@xxxxxxxxxxxxxxxxxx>]

Jürgen Gmach has proposed merging ~jugmac00/launchpad:upgrade-linters into launchpad:master.

Commit message:
Upgrade linters and run `pre-commit run --all-files`

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/429822
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:upgrade-linters into launchpad:master.

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 763ab02..03696aa 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -2,7 +2,7 @@
 # See https://pre-commit.com/hooks.html for more hooks
 repos:
 -   repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v3.2.0
+    rev: v4.3.0
     hooks:
     -   id: check-added-large-files
     -   id: check-ast
@@ -24,7 +24,7 @@ repos:
     -   id: no-commit-to-branch
         args: [--branch, master, --branch, db-devel]
 -   repo: https://github.com/asottile/pyupgrade
-    rev: v2.31.0
+    rev: v2.37.3
     hooks:
     -   id: pyupgrade
         args: [--keep-percent-format, --py3-plus]
@@ -34,7 +34,7 @@ repos:
             |utilities/community-contributions\.py
           )$
 -   repo: https://github.com/psf/black
-    rev: 22.3.0
+    rev: 22.8.0
     hooks:
       - id: black
         exclude: |
@@ -43,13 +43,13 @@ repos:
             |utilities/community-contributions\.py
           )$
 -   repo: https://github.com/PyCQA/isort
-    rev: 5.9.2
+    rev: 5.10.1
     hooks:
     -   id: isort
         name: isort
         args: [--profile, black]
 -   repo: https://github.com/PyCQA/flake8
-    rev: 3.9.2
+    rev: 5.0.4
     hooks:
     -   id: flake8
         exclude: ^lib/contrib/
@@ -61,7 +61,7 @@ repos:
     -   id: eslint
         args: [--quiet]
 -   repo: https://github.com/keewis/blackdoc
-    rev: v0.3.6
+    rev: v0.3.7
     hooks:
     -   id: blackdoc
         args: ["-l", "78"]
@@ -77,12 +77,12 @@ repos:
     hooks:
     -   id: shellcheck
 -   repo: https://github.com/codespell-project/codespell
-    rev: v2.1.0
+    rev: v2.2.1
     hooks:
     -   id: codespell
         files: ^doc/.*\.rst$
 -   repo: https://github.com/get-woke/woke
-    rev: v0.18.2
+    rev: v0.19.0
     hooks:
     -   id: woke-from-source
         files: ^doc/.*\.rst$
diff --git a/doc/malone.rst b/doc/malone.rst
index 64608fe..0cc5cdb 100644
--- a/doc/malone.rst
+++ b/doc/malone.rst
@@ -73,7 +73,7 @@ It's important that Malone be usable entirely in email. Many open source
 developers use their email to track work that needs to be done. So all of
 Malone's features should be accessible via email, including changing the
 status of a bug, adding and updating watches, and possibly also requesting
-reports of bugs on a product or distrbution.
+reports of bugs on a product or distribution.
 
 Distribution Bugs
 =================
diff --git a/lib/lp/archiveuploader/uploadprocessor.py b/lib/lp/archiveuploader/uploadprocessor.py
index 552f690..73bc9e1 100644
--- a/lib/lp/archiveuploader/uploadprocessor.py
+++ b/lib/lp/archiveuploader/uploadprocessor.py
@@ -96,7 +96,8 @@ __all__ = [
     "parse_upload_path",
 ]
 
-UPLOAD_PATH_ERROR_TEMPLATE = """Launchpad failed to process the upload path '%(upload_path)s':
+UPLOAD_PATH_ERROR_TEMPLATE = """\
+Launchpad failed to process the upload path '%(upload_path)s':
 
 %(path_error)s
 
diff --git a/lib/lp/services/oauth/tests/test_oauth.py b/lib/lp/services/oauth/tests/test_oauth.py
index a8d2e85..8fefef4 100644
--- a/lib/lp/services/oauth/tests/test_oauth.py
+++ b/lib/lp/services/oauth/tests/test_oauth.py
@@ -52,8 +52,14 @@ class OAuthConsumerTestCase(BaseOAuthTestCase):
 def test_suite():
     return unittest.TestSuite(
         (
-            unittest.makeSuite(OAuthAccessTokenTestCase),
-            unittest.makeSuite(OAuthRequestTokenTestCase),
-            unittest.makeSuite(OAuthConsumerTestCase),
+            unittest.defaultTestLoader.loadTestsFromTestCase(
+                OAuthAccessTokenTestCase
+            ),
+            unittest.defaultTestLoader.loadTestsFromTestCase(
+                OAuthRequestTokenTestCase
+            ),
+            unittest.defaultTestLoader.loadTestsFromTestCase(
+                OAuthConsumerTestCase
+            ),
         )
     )
diff --git a/lib/lp/soyuz/tests/fakepackager.py b/lib/lp/soyuz/tests/fakepackager.py
index ebafbb8..8894280 100644
--- a/lib/lp/soyuz/tests/fakepackager.py
+++ b/lib/lp/soyuz/tests/fakepackager.py
@@ -27,7 +27,8 @@ from lp.services.log.logger import BufferLogger
 from lp.soyuz.enums import PackageUploadStatus
 from lp.testing.gpgkeys import import_secret_test_key
 
-changelog_entry_template = """%(source_name)s (%(version)s) %(suite)s; urgency=low
+changelog_entry_template = """\
+%(source_name)s (%(version)s) %(suite)s; urgency=low
 
   * %(changelog_text)s