launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~cjwatson/launchpad:ci-mypy into launchpad:master

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: Colin Watson <mp+429818@xxxxxxxxxxxxxxxxxx>
Date: Tue, 13 Sep 2022 12:11:58 -0000
In-reply-to: <166306873502.6958.7903241793481696105.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+429818@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

@jugmac00 It seems to work fine, as you can see here - the only thing I had to put some work into dealing with was `version-info.py`.  I think we could reasonably just tell `mypy` to ignore missing imports for the things that are imported from system packages, if necessary.
-- 
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/429818
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:ci-mypy into launchpad:master.

References

[Merge] ~cjwatson/launchpad:ci-mypy into launchpad:master
From: Colin Watson, 2022-09-13