← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~andrey-fedoseev/launchpad:snap-base-features into launchpad:master

 

I do not know what a SnapBase is, and the docstring for ISnapBase isn't helpful at all ("A base for snaps."), but I still wonder whether we could initialize `features` as an empty dict, so we could save us those `is None` checks.
-- 
https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/431181
Your team Launchpad code reviewers is requested to review the proposed merge of ~andrey-fedoseev/launchpad:snap-base-features into launchpad:master.



Follow ups

References