launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #29289
Re: [Merge] ~andrey-fedoseev/launchpad:snap-base-features into launchpad:master
None is an existing value in the database that we need to account for.
On Fri, Oct 7, 2022, 11:17 Jürgen Gmach <mp+431181@xxxxxxxxxxxxxxxxxx>
wrote:
> I do not know what a SnapBase is, and the docstring for ISnapBase isn't
> helpful at all ("A base for snaps."), but I still wonder whether we could
> initialize `features` as an empty dict, so we could save us those `is None`
> checks.
> --
>
> https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/431181
> You are the owner of ~andrey-fedoseev/launchpad:snap-base-features.
>
>
--
https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/431181
Your team Launchpad code reviewers is requested to review the proposed merge of ~andrey-fedoseev/launchpad:snap-base-features into launchpad:master.
References