launchpad-reviewers team mailing list archive

[Andrey Fedoseev <mp+432249@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/services/features/browser/edit.py b/lib/lp/services/features/browser/edit.py
> index 3acc671..36ea7a3 100644
> --- a/lib/lp/services/features/browser/edit.py
> +++ b/lib/lp/services/features/browser/edit.py
> @@ -69,7 +69,7 @@ class FeatureControlView(LaunchpadFormView):
>  
>      def canSubmit(self, action):
>          """Is the user authorized to change the rules?"""
> -        return check_permission("launchpad.Admin", self.context)
> +        return check_permission("launchpad.EditFeatureRules", self.context)

The context here is `ILaunchpadRoot`. I think that granting `launchpad.Admin` permissions on that object to launchpad developers might have some undesired consequences. So, we need to apply a more granular approach, thus the new permission.

>  
>      @action("Change", name="change", condition=canSubmit)
>      def change_action(self, action, data):


-- 
https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/432249
Your team Launchpad code reviewers is requested to review the proposed merge of ~andrey-fedoseev/launchpad:edit-feature-rules into launchpad:master.