launchpad-reviewers team mailing list archive

[Colin Watson <mp+445188@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:clarify-domination-messages into launchpad:master.

Commit message:
Clarify domination logging a bit

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/445188

I wrote these log messages, and even I don't quite immediately associate "supersession" with "the act of superseding" (though that's the correct dictionary form).  Adjust these messages to be slightly more accessible.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:clarify-domination-messages into launchpad:master.

diff --git a/lib/lp/archivepublisher/domination.py b/lib/lp/archivepublisher/domination.py
index d705f81..466d1ba 100644
--- a/lib/lp/archivepublisher/domination.py
+++ b/lib/lp/archivepublisher/domination.py
@@ -708,7 +708,7 @@ class Dominator:
 
         def execute_plan():
             if supersede:
-                self.logger.info("Applying supersessions...")
+                self.logger.info("Superseding binaries...")
             for pub, dominant in supersede:
                 pub.supersede(dominant, logger=self.logger)
                 IStore(pub).flush()
@@ -723,7 +723,7 @@ class Dominator:
                             dominated.supersede(dominant, logger=self.logger)
                             IStore(dominated).flush()
             if delete:
-                self.logger.info("Applying deletions...")
+                self.logger.info("Deleting binaries...")
             for pub in delete:
                 pub.requestDeletion(None)
                 IStore(pub).flush()