launchpad-reviewers team mailing list archive

[Colin Watson <mp+445203@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad-layers:turnip-drop-resources into launchpad-layers:main.

Commit message:
turnip-base: Drop resource in favour of better Swift defaults

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad-layers/+git/launchpad-layers/+merge/445203

This was only ever for local development convenience, and it's usually much easier to just fetch the resource from Swift.  Now that we're trying to upload the charm to Charmhub, having a resource attached to it is an active impediment, because Charmhub doesn't have a good way to deal with optional resources; so just drop it and set defaults for `swift_container_name` and `swift_storage_url` so that things work better out of the box.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad-layers:turnip-drop-resources into launchpad-layers:main.

diff --git a/turnip-base/metadata.yaml b/turnip-base/metadata.yaml
deleted file mode 100644
index 4913e81..0000000
--- a/turnip-base/metadata.yaml
+++ /dev/null
@@ -1,5 +0,0 @@
-resources:
-  turnip:
-    type: file
-    filename: turnip.tar.gz
-    description: Turnip code