launchpad-reviewers team mailing list archive

[Colin Watson <mp+447523@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad-bastion-scripts:ignore-haproxy-queue-depth-checks into launchpad-bastion-scripts:main.

Commit message:
Ignore haproxy queue depth checks for production deployments

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad-bastion-scripts/+git/launchpad-bastion-scripts/+merge/447523

This doesn't mean that we should ignore them in general, just that they shouldn't block deployments.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad-bastion-scripts:ignore-haproxy-queue-depth-checks into launchpad-bastion-scripts:main.

diff --git a/upgrade-production b/upgrade-production
index 9c6a5a1..da01057 100755
--- a/upgrade-production
+++ b/upgrade-production
@@ -1,5 +1,10 @@
 #! /bin/sh
 set -e
 
+# Ignore haproxy queue depth checks for deployment purposes: they may need
+# to be handled by IS, but are unlikely to relate very closely to code
+# deployments.
+skip_checks=check_haproxy_queue_depth
+
 mkdir -p "$HOME/logs"
-ssh prod-launchpad@is-bastion-ps5.internal autodeploy-trigger prod-launchpad 2>&1 | tee -a "$HOME/logs/$(date +%F).log"
+ssh prod-launchpad@is-bastion-ps5.internal autodeploy-trigger prod-launchpad EXTRA_SKIP_CHECKS="$skip_checks" 2>&1 | tee -a "$HOME/logs/$(date +%F).log"