launchpad-reviewers team mailing list archive

[Colin Watson <mp+450646@xxxxxxxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:buildd-manager-bump-open-files into launchpad:master.

Commit message:
Bump buildd-manager open file limit some more

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/450646

We're bumping into the current limit on production, and I think it's because a few things have changed since we last set that limit: we have more active builders, and we make a few more outgoing connections than we did then (particularly to issue tokens for private builds).  Make the limit more generous.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:buildd-manager-bump-open-files into launchpad:master.

diff --git a/daemons/buildd-manager.tac b/daemons/buildd-manager.tac
index 876ecae..8fa2bac 100644
--- a/daemons/buildd-manager.tac
+++ b/daemons/buildd-manager.tac
@@ -31,9 +31,10 @@ setup_feature_controller("buildd-manager")
 # ampoule uses five file descriptors per subprocess (i.e.
 # 5 * config.builddmaster.download_connections); we also need at least three
 # per active builder for resuming virtualized builders or making XML-RPC
-# calls, and we also need to allow slack for odds and ends like database
-# connections.
-soft_nofile = 5 * config.builddmaster.download_connections + 2048
+# calls, we need to be able to make connections from time to time to the
+# keyserver for fetching keys or to the appserver for issuing macaroons, and
+# we also need to allow slack for odds and ends like database connections.
+soft_nofile = 5 * config.builddmaster.download_connections + 4096
 _, hard_nofile = resource.getrlimit(resource.RLIMIT_NOFILE)
 resource.setrlimit(resource.RLIMIT_NOFILE, (soft_nofile, hard_nofile))