launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #30558
Re: [Merge] ~lgp171188/rutabaga:add-readthedocs-yaml into rutabaga:master
Diff comments:
> diff --git a/setup.py b/setup.py
> index da1216e..59a1567 100644
> --- a/setup.py
> +++ b/setup.py
> @@ -20,16 +20,24 @@ requires = [
> 'PyYAML',
> 'waitress',
> ]
> +docs_requires = [
> + 'cornice',
> + 'cornice_sphinx',
> + 'docutils<0.18',
> + 'Jinja2<3.1.0',
> + 'PyYAML',
> + 'Sphinx<2.1',
> +]
There were known compatibility issues that caused the sphinx build to throw errors and warnings. So I had to pin some dependencies to get it working.
> +deploy_requires = [
> + 'envdir',
> + 'gunicorn',
> + ]
> test_requires = [
> 'fixtures',
> 'flake8',
> 'testtools',
> 'webtest',
> ]
> -deploy_requires = [
> - 'envdir',
> - 'gunicorn',
> - ]
>
> setup(
> name='rutabaga',
--
https://code.launchpad.net/~lgp171188/rutabaga/+git/rutabaga/+merge/452819
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/rutabaga:add-readthedocs-yaml into rutabaga:master.
References