launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~xnox/launchpad:only-sha256 into launchpad:master

To: Dimitri John Ledkov <dimitri.ledkov+lp@xxxxxxxxxxxxx>
From: Seth Arnold <mp+452749@xxxxxxxxxxxxxxxxxx>
Date: Fri, 15 Dec 2023 01:40:33 -0000
In-reply-to: <169641443863.1290376.11401050162651515039.launchpad@juju-98d295-prod-launchpad-16>
Reply-to: mp+452749@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

> Note Description-md5 is intentionally left in place, as it's actually just a string compare key, and not security sensitive.

The presence of md5 means that someone, somewhere, is going to need to justify why this case is fine, and how it doesn't have security relevance, and say that the Description: field of packages isn't actually all that important in their environment etc.

Would we be better off removing md5 entirely while we're here rather than just the ones that waste bandwidth, storage, and cpu?

Thanks
-- 
https://code.launchpad.net/~xnox/launchpad/+git/launchpad/+merge/452749
Your team Launchpad code reviewers is requested to review the proposed merge of ~xnox/launchpad:only-sha256 into launchpad:master.