launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~xnox/launchpad:only-sha256 into launchpad:master

To: Dimitri John Ledkov <dimitri.ledkov+lp@xxxxxxxxxxxxx>
From: Seth Arnold <mp+452749@xxxxxxxxxxxxxxxxxx>
Date: Fri, 15 Dec 2023 02:09:34 -0000
In-reply-to: <169641443863.1290376.11401050162651515039.launchpad@juju-98d295-prod-launchpad-16>
Reply-to: mp+452749@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

I don't know the launchpad internals well, so the scope of my review is very limited. I can't say what this patch might have overlooked elsewhere.

The mechanics of this patch looks good to me. It looks like I expect.

I'm unsure whether to roll out changes gradually, starting with 24.04 LTS, or to implement the change across all releases at once. I usually prefer preserving functionality, but having one release different from the others could cause more problems than benefits.

Thanks
-- 
https://code.launchpad.net/~xnox/launchpad/+git/launchpad/+merge/452749
Your team Launchpad code reviewers is requested to review the proposed merge of ~xnox/launchpad:only-sha256 into launchpad:master.