launchpad-reviewers team mailing list archive

[Ines Almeida <mp+464821@xxxxxxxxxxxxxxxxxx>]

Review: Approve

Looks good!

Can you update the commit message to start with the model in question?

I.e.
```
lp-fetch-service: Deploy fetch-service charm from Charmhub
```

Diff comments:

> diff --git a/lp-fetch-service/bundle.yaml b/lp-fetch-service/bundle.yaml
> index 8bd8dd3..67472ee 100644
> --- a/lp-fetch-service/bundle.yaml
> +++ b/lp-fetch-service/bundle.yaml
> @@ -16,9 +16,11 @@ applications:
>          public. Currently, this expects the charm and snap to be copied to the
>          path where the bundle.yaml is rendered, in the mojo project folder (eg.
>          .../mojo/lp-fetch-service/jammy/devel/charms/lp-fetch-service/). #}
> -    charm: "./fetch-service_ubuntu-22.04-amd64.charm"
> -    resources:
> -      snap: "./fetch-service.snap"
> +    charm: ch:fetch-service
> +    channel: edge
> +    revision: 4
>      num_units: 1
>      expose: true
> +    options:
> +        channel: "latest/edge"

I'm guessing this is the snap channel? If so can you add a quick comment here saying so?

>  {%- endif %}


-- 
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/464821
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:master.