launchpad-reviewers team mailing list archive

[Simone Pelosi <mp+464838@xxxxxxxxxxxxxxxxxx>]

Simone Pelosi has proposed merging ~pelpsi/launchpad:unembargo-buildinfo-file into launchpad:master.

Commit message:
Unembargo build info

Added buildinfo to unembargoed files.

LP: #2052796

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #2052796 in Launchpad itself: "MIssing buildinfo file for Jammy grub2-unsigned 2.06-2ubuntu14.4"
  https://bugs.launchpad.net/launchpad/+bug/2052796

For more details, see:
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/464838
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad:unembargo-buildinfo-file into launchpad:master.

diff --git a/lib/lp/soyuz/scripts/packagecopier.py b/lib/lp/soyuz/scripts/packagecopier.py
index f377107..bc31af0 100644
--- a/lib/lp/soyuz/scripts/packagecopier.py
+++ b/lib/lp/soyuz/scripts/packagecopier.py
@@ -87,6 +87,8 @@ def update_files_privacy(pub_record):
         package_files.append((package_upload, "changesfile"))
         # Unrestrict the buildlog file as necessary.
         package_files.append((build, "log"))
+        # Unrestrict the buildinfo file as necessary.
+        package_files.append((build, "buildinfo"))
     elif IPackageUploadCustom.providedBy(pub_record):
         # Unrestrict the custom files included
         package_files.append((pub_record, "libraryfilealias"))
diff --git a/lib/lp/soyuz/tests/test_packagecopyjob.py b/lib/lp/soyuz/tests/test_packagecopyjob.py
index 26fdd08..033dd6a 100644
--- a/lib/lp/soyuz/tests/test_packagecopyjob.py
+++ b/lib/lp/soyuz/tests/test_packagecopyjob.py
@@ -1757,6 +1757,12 @@ class PlainPackageCopyJobTests(TestCaseWithFactory, LocalTestHelper):
             distroseries=self.distroseries,
             status=PackagePublishingStatus.PUBLISHED,
         )
+        [build] = spph.getBuilds()
+        build.addBuildInfo(
+            self.factory.makeLibraryFileAlias(
+                filename="build_info.info", restricted=True
+            )
+        )
         spr = spph.sourcepackagerelease
         for source_file in spr.files:
             self.assertTrue(source_file.libraryfile.restricted)
@@ -1837,6 +1843,7 @@ class PlainPackageCopyJobTests(TestCaseWithFactory, LocalTestHelper):
             copied_build = copied_binary.binarypackagerelease.build
             self.assertFalse(copied_build.upload_changesfile.restricted)
             self.assertFalse(copied_build.log.restricted)
+            self.assertFalse(copied_build.buildinfo.restricted)
 
     def test_copy_custom_upload_files(self):
         # Copyable custom upload files are queued for republication when